Introduce pre-commit config for flake8 by ulgens · Pull Request #1338 · graphql-python/graphene-django
Navigation Menu
{{ message }}
graphql-python / graphene-django Public
- Notifications You must be signed in to change notification settings
- Fork 766
Merged
Conversation
Copy link
Collaborator
ulgens
commented
Aug 16, 2022
ulgens
commented
A light intro of pre-commit for v2 branch. Replaces flake8 in CI for starters.
Copy link
Collaborator Author
ulgens
commented
Aug 16, 2022
ulgens commented
Aug 16, 2022
ulgens
self-assigned this
ulgens
changed the title
Introduce pre-commit config for flake8 (v2)
Introduce pre-commit config for flake8
ulgens
mentioned this pull request
Copy link
Contributor
nikolaik
commented
Aug 16, 2022
nikolaik commented
Aug 16, 2022Nice gradual approach @ulgens love it!
erikwrede approved these changes Aug 18, 2022
Copy link
Member
erikwrede
left a comment
erikwrede
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
ulgens
merged commit
12ec3ca
into
v2
ulgens
deleted the
pre-commit-setup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment