fix: empty list is not an empty value for list filters even when a custom filtering method is provided by tcleonard · Pull Request #1450 · graphql-python/graphene-django
Conversation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, and thanks for adding the tests!
@tcleonard long time! glad you have time to make great contributions like before!
is this still a WIP?
I just pushed an update taking into account your suggestion and revamping the tests. Let me know what you think
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for handling the ArrayField as well and for adding more test coverage there too (and nice job getting a workaround for non-Postgres environments)!
…stom filtering method is provided
if anyone of you has merge permissions (I don't seem to have them anymore), could you merge this please? 🙏
tcleonard
deleted the
fix/list-filter-custom-method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters