Only release on pypi after tests pass by kiendang · Pull Request #1452 · graphql-python/graphene-django
Navigation Menu
{{ message }}
graphql-python / graphene-django Public
- Notifications You must be signed in to change notification settings
- Fork 766
Merged
Only release on pypi after tests pass#1452
firaskafri merged 1 commit intomainfrom
Only release on pypi after tests pass#1452
firaskafri merged 1 commit intomainfrom
Conversation
Copy link
Contributor
kiendang
commented
Aug 11, 2023
kiendang
commented
Context #1448 (comment)
Relevant GHA docs workflow_call, needs
kiendang
requested review from
firaskafri and
sjdemartini
sjdemartini approved these changes Aug 11, 2023
Copy link
Collaborator
sjdemartini
left a comment
sjdemartini
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks so much for adding this! This is the same approach/syntax I used in a frontend package I maintain and it works well there
firaskafri
merged commit
720db1f
into
main
firaskafri
deleted the
test-before-release
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants