Use ruff format to replace black by kiendang · Pull Request #1473 · graphql-python/graphene-django

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kiendang

Copy link

Contributor

Ruff formatter (a black-compatible code formatter built into ruff) is out of beta today https://astral.sh/blog/the-ruff-formatter.
Replace the black pre-commit hook with ruff-format hook for faster formatting.

Copy link

Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! ruff ftw! Thank you!

@firaskafri firaskafri merged commit 36cf100 into main

Oct 25, 2023

@firaskafri firaskafri deleted the ruff-format branch

October 25, 2023 08:33

superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request

Dec 6, 2023
* Use ruff format to replace black

* Adjust ruff config to be compatible with ruff-format

https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules

* Format

* Replace black with ruff format in Makefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjdemartini sjdemartini sjdemartini approved these changes

@firaskafri firaskafri firaskafri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiendang @sjdemartini @firaskafri