Remove Django 4.1 (EOL) and add Django 5.0 to CI by kiendang · Pull Request #1483 · graphql-python/graphene-django
Navigation Menu
{{ message }}
graphql-python / graphene-django Public
- Notifications You must be signed in to change notification settings
- Fork 766
Merged
Remove Django 4.1 (EOL) and add Django 5.0 to CI#1483
firaskafri merged 1 commit intomainfrom
Remove Django 4.1 (EOL) and add Django 5.0 to CI#1483
firaskafri merged 1 commit intomainfrom
Conversation
Copy link
Contributor
kiendang
requested review from
firaskafri,
sjdemartini and
ulgens
sjdemartini approved these changes Dec 8, 2023
Copy link
Collaborator
sjdemartini
left a comment
sjdemartini
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice to see 5.0 passed all tests without any changes 😄
Copy link
Contributor Author
kiendang
commented
Dec 8, 2023
kiendang commented
Dec 8, 2023Looks great! Nice to see 5.0 passed all tests without any changes 😄
Yup. Turned out that 1 failed test was with djangomain and we don't need to worry about that until future releases.
firaskafri
merged commit
db2d40e
into
main
firaskafri
deleted the
django-5
branch
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request
Jan 30, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants