Allows field's choices to be a callable by nossila · Pull Request #1497 · graphql-python/graphene-django
Navigation Menu
{{ message }}
graphql-python / graphene-django Public
- Notifications You must be signed in to change notification settings
- Fork 766
Merged
Allows field's choices to be a callable#1497
kiendang merged 3 commits intographql-python:mainfrom
Allows field's choices to be a callable#1497
kiendang merged 3 commits intographql-python:mainfrom
Conversation
Copy link
Contributor
nossila
commented
Feb 7, 2024
nossila
commented
Starting in Django 5 field's choices can also be a callable https://docs.djangoproject.com/en/5.0/ref/models/fields/#django.db.models.Field.choices
Starting in Django 5 field's choices can also be a callable
Copy link
Contributor
kiendang
commented
Feb 7, 2024
kiendang commented
Feb 7, 2024Thanks @nossila could you also add a test for this?
nossila and others added 2 commits
February 7, 2024 15:18kiendang approved these changes Mar 20, 2024
Copy link
Contributor
kiendang
left a comment
kiendang
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @nossila!
sjdemartini approved these changes Mar 20, 2024
Copy link
Collaborator
sjdemartini
left a comment
sjdemartini
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
kiendang
merged commit
45c2aa0
into
graphql-python:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants