Strip HTML tags from newscap notification messages by crwood · Pull Request #211 · gridsync/gridsync
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 26
Conversation
Copy link
Member
crwood
commented
May 23, 2019
crwood
commented
A minor follow-up/improvement to #192: Qt5's QMessageBox will correctly render HTML tags included in newscap messages but native desktop notification popup windows will not. In order to make the text in desktop notification popup windows render similarly to the text shown in QMessageBoxes, this PR replaces HTML <p> tags with newlines and strips other tags from newscap messages (using the python standard library's html.parser.HTMLParser), thereby preventing un-rendered HTML from showing up in desktop notifications.
crwood added 5 commits
May 22, 2019 16:43
crwood
merged commit
c21a1b1
into
master
crwood
deleted the
strip-notification-html-tags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment