Strip HTML tags from newscap notification messages by crwood · Pull Request #211 · gridsync/gridsync

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@crwood

Copy link

Member

@crwood crwood commented

May 23, 2019

A minor follow-up/improvement to #192: Qt5's QMessageBox will correctly render HTML tags included in newscap messages but native desktop notification popup windows will not. In order to make the text in desktop notification popup windows render similarly to the text shown in QMessageBoxes, this PR replaces HTML <p> tags with newlines and strips other tags from newscap messages (using the python standard library's html.parser.HTMLParser), thereby preventing un-rendered HTML from showing up in desktop notifications.

@crwood crwood merged commit c21a1b1 into master

May 23, 2019

@crwood crwood deleted the strip-notification-html-tags branch

May 23, 2019 01:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@crwood