Update pyqtchart nix expression. by tomprince · Pull Request #379 · gridsync/gridsync

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

crwood merged 2 commits intogridsync:290.new-magic-folderfrom

tp-la:pyqtchart

Sep 14, 2021

Merged

Update pyqtchart nix expression.#379

crwood merged 2 commits intogridsync:290.new-magic-folderfrom

tp-la:pyqtchart

Conversation

@tomprince

Copy link

Contributor

See #378.

I've not actually run this, but it does build.

cc: @exarkun

@exarkun

Copy link

Contributor

exarkun commented

Sep 1, 2021

Thanks @tomprince. I can confirm this builds for me and I can run the resulting GridSync. I see a GUI window before it gives up from not being able to find magic-folder and exits. I think that means this is a good change. I have another branch elsewhere where I'm working on adding magic-folder to the Nix packaging and this will help that along a bunch. This also looks like a better job than any of the Nix/Qt packaging work I've done so far.

@exarkun

Copy link

Contributor

exarkun commented

Sep 1, 2021

@crwood I'd be happy to see this merged.

@crwood

Copy link

Member

crwood commented

Sep 14, 2021

Apologies for letting this slip under the radar; merging...

@crwood crwood merged commit 31ce0f2 into gridsync:290.new-magic-folder

Sep 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomprince @exarkun @crwood