Handle new lease crawler configuration items by exarkun · Pull Request #418 · gridsync/gridsync
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 26
Merged
crwood merged 6 commits intogridsync:masterfrom
Dec 8, 2021Merged
Handle new lease crawler configuration items#418
crwood merged 6 commits intogridsync:masterfrom
Handle new lease crawler configuration items#418
crwood merged 6 commits intogridsync:masterfrom
Conversation
Copy link
Contributor
exarkun
commented
Dec 7, 2021
exarkun
commented
Fixes #417
These items are all optional. It's not necessary to update ZKAPAuthorizer for these changes to be valid (they just won't do anything until ZKAPAuthorizer is updated). There is still at least one more related ZKAPAuthorizer change to make before any of this will particularly help GridSync so it's not worth making that update yet.
exarkun added 6 commits
December 7, 2021 10:02This makes it easier to identify the ZKAPAuthorizer pieces and easier to test them directly.
Copy link
Member
crwood
commented
Dec 8, 2021
crwood commented
Dec 8, 2021Thanks for this. Looks good to me... My only suggestion here would be to use pytest.mark.parametrize to deduplicate some of those tests (since, in many cases, they structurally equivalent to one another and differ only according to the values being passed/checked) but this is mostly a minor cosmetic preference on my part and I'm happy to merge this as-is.
crwood
merged commit
62a3d95
into
gridsync:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment