Handle new lease crawler configuration items by exarkun · Pull Request #418 · gridsync/gridsync

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@exarkun

Copy link

Contributor

@exarkun exarkun commented

Dec 7, 2021

Fixes #417

These items are all optional. It's not necessary to update ZKAPAuthorizer for these changes to be valid (they just won't do anything until ZKAPAuthorizer is updated). There is still at least one more related ZKAPAuthorizer change to make before any of this will particularly help GridSync so it's not worth making that update yet.

@crwood

Copy link

Member

crwood commented

Dec 8, 2021

Thanks for this. Looks good to me... My only suggestion here would be to use pytest.mark.parametrize to deduplicate some of those tests (since, in many cases, they structurally equivalent to one another and differ only according to the values being passed/checked) but this is mostly a minor cosmetic preference on my part and I'm happy to merge this as-is.

@crwood crwood merged commit 62a3d95 into gridsync:master

Dec 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transpose ZKAPAuthorizer lease crawler configuration to the appropriate place

2 participants

@exarkun @crwood