Desktop notification fallbacks by crwood · Pull Request #474 · gridsync/gridsync
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 26
Merged
Conversation
Copy link
Member
crwood
commented
May 21, 2022
crwood
commented
This PR makes some minor adjustments to desktop.notify with the aim of providing working fallback mechanisms for desktop environments that don't support traditional desktop notifications:
- On Linux-like systems, actually catch and handle exceptions raised by txbus calls in the event that, e.g., the host operating system lacks DBus (these exceptions were previously uncaught due to missing
yieldstatement...) - Show a popup message via
QSystemTray.showMessageiff the systray actually supports messages - Fall back to logging the message, if all else fails
crwood added 2 commits
May 20, 2022 23:38
crwood
merged commit
e464741
into
master
crwood
deleted the
desktop-notification-fallbacks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment