Add missing type annotations by crwood · Pull Request #502 · gridsync/gridsync

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

Conversation

@crwood

Copy link

Member

@crwood crwood commented

Jul 19, 2022

This PR adds type annotations for the remaining Gridsync modules that did not previously have them and enables mypy type checking globally. Some additional, minor changes were made along the way in support of this goal (e.g., changing/updating some default attribute values, updating tests, addressing warnings/errors uncaught previously by mypy, etc.) but these changes were mostly non-functional in nature.

crwood added 30 commits

July 3, 2022 12:06
Otherwise, this appears to throw a `has-type` mypy warning under Qt6

crwood added 28 commits

July 17, 2022 15:10

@crwood crwood merged commit b59e51c into master

Jul 19, 2022

@crwood crwood deleted the type-annotations branch

July 25, 2022 21:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@crwood