add data probe by i-n-g-o · Pull Request #103 · gstreamer-java/gst1-java-core

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@i-n-g-o

Copy link

Contributor

@i-n-g-o i-n-g-o commented

Jun 12, 2018

No description provided.

@neilcsmith-net

Copy link

Member

Thanks for this!

Descriptions welcomed, particularly with links to relevant upstream docs! 😄

return listener.dataReceived(pad, buffer);
}

//We have to negate the return value to keep consistency with gstreamer's API
Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does this comment mean?

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is actually a copied comment from addEventProbe. no idea what it means :D

@neilcsmith-net neilcsmith-net merged commit 8bef024 into gstreamer-java:master

Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilcsmith-net neilcsmith-net neilcsmith-net left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@i-n-g-o @neilcsmith-net