add getTemplate, add getter for PadTemplate, add PadTemplateTest by i-n-g-o · Pull Request #105 · gstreamer-java/gst1-java-core
Navigation Menu
{{ message }}
gstreamer-java / gst1-java-core Public
- Notifications You must be signed in to change notification settings
- Fork 71
Merged
neilcsmith-net merged 2 commits intogstreamer-java:masterfrom
Jun 13, 2018Merged
add getTemplate, add getter for PadTemplate, add PadTemplateTest#105
neilcsmith-net merged 2 commits intogstreamer-java:masterfrom
add getTemplate, add getter for PadTemplate, add PadTemplateTest#105
neilcsmith-net merged 2 commits intogstreamer-java:masterfrom
Conversation
Copy link
Contributor
i-n-g-o
commented
Jun 12, 2018
i-n-g-o
commented
actually i'm not sure about how to get template-name, direction, presence. there might be a better solution for this. maybe getting the data from the lowlevel structure to avoid this ugly casting stuff...
it works though.
Copy link
Member
neilcsmith-net
commented
Jun 13, 2018
neilcsmith-net commented
Jun 13, 2018Can you rebase (or reopen) against master? Got a merge conflict with your other PR. Thanks!
Copy link
Contributor Author
i-n-g-o
commented
Jun 13, 2018
i-n-g-o commented
Jun 13, 2018yes, sure.
Copy link
Contributor Author
i-n-g-o
commented
Jun 13, 2018
i-n-g-o commented
Jun 13, 2018should be fine to merge now
Copy link
Member
neilcsmith-net
commented
Jun 13, 2018
neilcsmith-net commented
Jun 13, 2018Thanks! Will merge. Not sure that I like the number to enum conversion, but can't think of a nicer way at the moment - will have a look later.
neilcsmith-net
merged commit
32b74a8
into
gstreamer-java:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment