add getTemplate, add getter for PadTemplate, add PadTemplateTest by i-n-g-o · Pull Request #105 · gstreamer-java/gst1-java-core

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@i-n-g-o

Copy link

Contributor

@i-n-g-o i-n-g-o commented

Jun 12, 2018

actually i'm not sure about how to get template-name, direction, presence. there might be a better solution for this. maybe getting the data from the lowlevel structure to avoid this ugly casting stuff...
it works though.

@neilcsmith-net

Copy link

Member

Can you rebase (or reopen) against master? Got a merge conflict with your other PR. Thanks!

@i-n-g-o

Copy link

Contributor Author

i-n-g-o commented

Jun 13, 2018

yes, sure.

@i-n-g-o

Copy link

Contributor Author

i-n-g-o commented

Jun 13, 2018

should be fine to merge now

@neilcsmith-net

Copy link

Member

Thanks! Will merge. Not sure that I like the number to enum conversion, but can't think of a nicer way at the moment - will have a look later.

@neilcsmith-net neilcsmith-net merged commit 32b74a8 into gstreamer-java:master

Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@i-n-g-o @neilcsmith-net