#3457 increase max length of VAR* types by grandinj · Pull Request #3464 · h2database/h2database
Navigation Menu
{{ message }}
h2database / h2database Public
- Notifications You must be signed in to change notification settings
- Fork 1.3k
Merged
grandinj merged 7 commits intoh2database:masterfrom
Mar 30, 2022Merged
#3457 increase max length of VAR* types#3464
grandinj merged 7 commits intoh2database:masterfrom
#3457 increase max length of VAR* types#3464
grandinj merged 7 commits intoh2database:masterfrom
Conversation
katzyn reviewed Mar 24, 2022
| * encoding data fields when storing rows. | ||
| */ | ||
| public static final int MAX_STRING_LENGTH = 1024 * 1024; | ||
| public static final int MAX_STRING_LENGTH = 1024 * 1024 * 1024; |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 1_000_000_000 as specified in documentation.
1024^3 is actually larger than actual limit of java.lang.String since Java 9 (for strings with at least one character with code larger than 255).
grandinj added 6 commits
March 24, 2022 15:19to match the new documented value
which should speed it up
there is no way to test this without using up so much memory we'd probably get flagged for abusing CI
causes OOM on CI
grandinj
merged commit
e254352
into
h2database:master
timonzi
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants