Improve memory estimation of CacheLongKeyLIRS and correct some passed memory sizes by katzyn · Pull Request #3626 · h2database/h2database
Navigation Menu
{{ message }}
h2database / h2database Public
- Notifications You must be signed in to change notification settings
- Fork 1.3k
Merged
Improve memory estimation of CacheLongKeyLIRS and correct some passed memory sizes#3626
katzyn merged 4 commits intoh2database:masterfrom
Improve memory estimation of CacheLongKeyLIRS and correct some passed memory sizes#3626
katzyn merged 4 commits intoh2database:masterfrom
Conversation
Copy link
Contributor
katzyn
commented
Sep 11, 2022
katzyn
commented
- Maximum size of
CacheLongKeyLIRSnow includes approximate size of the cache itself. It doesn't have any significant impact when large objects are cached, but it prevents excessive memory usage when very small objects are cached. - Incorrect sizes of objects passed to
MVStore.chunksToCare corrected. - Default object size is changed from 1 byte to 16 bytes (typical size of
java.lang.Object). - Size of a cached object is now stored as
longto prevent possible overflows (with large cached arrays, for example).
Related issue: #3625
katzyn added 4 commits
September 11, 2022 17:24andreitokar approved these changes Sep 11, 2022
Copy link
Contributor
andreitokar
left a comment
andreitokar
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
katzyn
merged commit
067969f
into
h2database:master
katzyn
deleted the
cache
branch
JinuCheon
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment