simplify Store#close by grandinj · Pull Request #4168 · h2database/h2database
Navigation Menu
{{ message }}
h2database / h2database Public
- Notifications You must be signed in to change notification settings
- Fork 1.3k
Merged
grandinj merged 1 commit intoh2database:masterfrom
Dec 1, 2024Merged
simplify Store#close#4168
grandinj merged 1 commit intoh2database:masterfrom
simplify Store#close#4168
grandinj merged 1 commit intoh2database:masterfrom
Conversation
Copy link
Contributor
grandinj
commented
Nov 29, 2024
grandinj
commented
We call MVStore#close() here, and that also implements the "full compact on close" on logic, so no need to duplicate that here.
We call MVStore#close() here, and that also implements the "full compact on close" on logic, so no need to duplicate that here.
andreitokar approved these changes Nov 30, 2024
Copy link
Contributor
andreitokar
left a comment
andreitokar
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
grandinj
merged commit
d46a383
into
h2database:master
DropSnorz
mentioned this pull request
naive924
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants