Home Original page

feature/dev 1879 improve contrast on certain elements by stanley2058 · Pull Request #1899 · hackmdio/codimd

@stanley2058

Improve contrast of UI elements:

  • Default theme now has higher contrast linenumber & code comments.
    The link buttons in the navbar, last changed at, and the action button on the top right are now more visible in dark mode.
  • Fix an issue where the theme name would not be visible when hovering under dark mode.

Before:
Screenshot_20250321_115308

After:
Screenshot_20250321_115243

The color of active line is also updated:
(Before)
image
(After)
image

Signed-off-by: stanley2058 <stanley2058@yahoo.com.tw>
Signed-off-by: stanley2058 <stanley2058@yahoo.com.tw>

@stanley2058 stanley2058 linked an issue

Mar 21, 2025

that may be closed by this pull request

jackycute

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the contrast of UI elements, particularly enhancing dark mode readability by adding the one-dark.css file and making various theme adjustments.

  • Adds one-dark.css to the webpack build for updated dark mode support
  • Improves contrast for key UI components such as link buttons and theme names
Files not reviewed (3)
  • public/css/codemirror-extend/one-dark.css: Language not supported
  • public/css/extra.css: Language not supported
  • public/css/index.css: Language not supported

@Yukaii Yukaii deleted the feature/dev-1879-improve-contrast-on-certain-elements branch

May 15, 2025 06:00