fix: login email should be case insensitive by DubMythlit · Pull Request #1911 · hackmdio/codimd
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Merged
Yukaii merged 1 commit intohackmdio:developfrom
May 15, 2025Merged
fix: login email should be case insensitive#1911
Yukaii merged 1 commit intohackmdio:developfrom
fix: login email should be case insensitive#1911
Yukaii merged 1 commit intohackmdio:developfrom
Conversation
Copy link Copy Markdown
Contributor
DubMythlit
commented
Apr 24, 2025
DubMythlit
commented
fix #1744
By query email in lower case makes login be case insensitive now
tested on: Postgres12 & sqlite3
jackycute reviewed Apr 30, 2025
lib/auth/email/index.js
Outdated
Show resolved
Hide resolved
lib/auth/email/index.js Outdated Show resolved Hide resolved
Copy link Copy Markdown
Member
jackycute
commented
Apr 30, 2025
jackycute commented
Apr 30, 2025Hi @Dubmyhtlit,
Thanks for your PR,
Please also sign off your commit like this:
commit message
Signed-off-by: XXX <xxx@example.com>
Copy link Copy Markdown
Member
@DubMythlit You have to signoff every commit:
git rebase --signoff -i develop
then do a force push to update branch
jackycute
requested a review
from Yukaii
Yukaii
modified the milestones:
Next,
2.6.0
Signed-off-by: Hsiang-Yang Hsieh <arcadian424@gmail.com>
DubMythlit
force-pushed
the
bugfix/email-case-insensitive
branch
from
6a30de9 to
d4ccba9
Compare
Yukaii approved these changes May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants