Fix typo in license name by akowal · Pull Request #247 · hamcrest/JavaHamcrest
Navigation Menu
{{ message }}
hamcrest / JavaHamcrest Public
- Notifications You must be signed in to change notification settings
- Fork 386
Merged
Conversation
Copy link Copy Markdown
Contributor
akowal
commented
Jan 22, 2019
akowal
commented
Change license name from "BSD Licence 3" to "BSD License 3". This typo
fails automated license checks in a project that has
hamcrest dependency.
Change license name from "BSD Licence 3" to "BSD License 3". This typo fails automated license checks in a project that has hamcrest dependency.
Copy link Copy Markdown
Member
zaphod42
commented
Jan 22, 2019
zaphod42 commented
Jan 22, 2019This isn't to say that the change should be rejected. I do want to point out that "licence" with a "c" is not a typo. It is an alternative spelling for the word. "License" with and "s" is the American spelling. As this is a project primarly by people in the UK it is understandable the the non-American spelling is used in the project.
Copy link Copy Markdown
Contributor Author
akowal
commented
Jan 22, 2019
akowal commented
Jan 22, 2019@zaphod42 In this case it's not about spelling difference. It is a typo since correct name of the license is BSD License as per LICENSE.TXT.
sf105
merged commit
885fd9d
into
hamcrest:master
Copy link Copy Markdown
Member
sf105
commented
Jan 22, 2019
sf105 commented
Jan 22, 2019Accepted. For curiosity, what is the check that’s running?
Copy link Copy Markdown
Contributor Author
akowal
commented
Jan 22, 2019
akowal commented
Jan 22, 2019This was referenced
Apr 29, 2021This was referenced
May 12, 2021This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment