Add BitTiming/BitTimingFd support to KvaserBus by zariiii9003 · Pull Request #1510 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
zariiii9003 merged 4 commits intohardbyte:developfrom
Oct 16, 2023Merged
Add BitTiming/BitTimingFd support to KvaserBus#1510
zariiii9003 merged 4 commits intohardbyte:developfrom
Add BitTiming/BitTimingFd support to KvaserBus#1510
zariiii9003 merged 4 commits intohardbyte:developfrom
Conversation
Copy link
Collaborator
zariiii9003
commented
Jan 27, 2023
zariiii9003
commented
Can someone with a Kvaser device test KvaserBus instantiation with BitTiming and BitTimingFd?
zariiii9003
added
help wanted
backend:kvaser
labels
zariiii9003
added this to the
Next Release milestone
zariiii9003
force-pushed
the
bittiming_kvaser
branch
from
f6da621 to
7b7242c
Compare
zariiii9003
mentioned this pull request
zariiii9003 added 2 commits
October 13, 2023 15:56
zariiii9003
force-pushed
the
bittiming_kvaser
branch
from
7b7242c to
0e39fe9
Compare
zariiii9003
marked this pull request as ready for review
zariiii9003
requested a review
from lumagi
Copy link
Collaborator Author
zariiii9003
commented
Oct 14, 2023
zariiii9003 commented
Oct 14, 2023@lumagi I'd like to include this one in 4.3. We'll start with a release candidate anyway. Could you take a look?
lumagi reviewed Oct 16, 2023
can/interfaces/kvaser/canlib.py
Show resolved
Hide resolved
can/interfaces/kvaser/canlib.py Show resolved Hide resolved
lumagi approved these changes Oct 16, 2023
Copy link
Collaborator
lumagi
left a comment
lumagi
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very fine to me. I think the legacy code paths should be executed just fine in case no timing parameter is passed.
can/interfaces/kvaser/canlib.py
Show resolved
Hide resolved
can/interfaces/kvaser/canlib.py Show resolved Hide resolved
zariiii9003 added 2 commits
October 16, 2023 22:18
zariiii9003
merged commit
2d60900
into
hardbyte:develop
zariiii9003
deleted the
bittiming_kvaser
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment