BigEndian test fixes by umlaeute · Pull Request #1625 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
zariiii9003 merged 1 commit intohardbyte:developfrom
Jun 30, 2023Merged
BigEndian test fixes#1625
zariiii9003 merged 1 commit intohardbyte:developfrom
BigEndian test fixes#1625
zariiii9003 merged 1 commit intohardbyte:developfrom
Conversation
Copy link
Contributor
umlaeute
commented
Jun 29, 2023
umlaeute
commented
- PCAN_BITRATES are stored in BIGendian, no use to byteswap on littleendian.
- Also the TPCANChannelInformation expects data in the native byte order
Closes: #1624
PCAN_BITRATES are stored in BIGendian, no use to byteswap on littleendian. Also the TPCANChannelInformation expects data in the native byte order Closes: hardbyte#1624
umlaeute
force-pushed
the
bugfix/bigendian-tests
branch
from
9ead196 to
4d1794f
Compare
zariiii9003 approved these changes Jun 30, 2023
Copy link
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
zariiii9003
merged commit
c5d7a7c
into
hardbyte:develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants