We do not need to account for drift when we USE_WINDOWS_EVENTS by pierreluctg · Pull Request #1666 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
We do not need to account for drift when we USE_WINDOWS_EVENTS#1666
pierreluctg merged 4 commits intodevelopfrom
We do not need to account for drift when we USE_WINDOWS_EVENTS#1666
pierreluctg merged 4 commits intodevelopfrom
Conversation
Copy link
Collaborator
When using USE_WINDOWS_EVENTS the waitable timer will be fired at fixed rate, we do not need to account for the drift.
The change makes it wait for the timer to be in signaled state only.
Previous code was causing multiple frames to be send back to back without delay.
pierreluctg added 3 commits
September 27, 2023 16:02
pierreluctg
requested a review
from zariiii9003
pierreluctg
marked this pull request as ready for review
pierreluctg
changed the title
We do not need to account for drift when USE_WINDOWS_EVENTS
We do not need to account for drift when we USE_WINDOWS_EVENTS
pierreluctg
added
os:windows
bug
labels
Copy link
Collaborator Author
pierreluctg
commented
Sep 29, 2023
pierreluctg commented
Sep 29, 2023@zariiii9003 please review
zariiii9003 reviewed Oct 1, 2023
can/broadcastmanager.py
Outdated
Show resolved
Hide resolved
can/broadcastmanager.py Outdated Show resolved Hide resolved
pierreluctg
requested a review
from zariiii9003
zariiii9003 approved these changes Oct 2, 2023
pierreluctg
merged commit
3c3f123
into
develop
pierreluctg
deleted the
USE_WINDOWS_EVENTS
branch
pierreluctg
added this to the
Next Release milestone
zariiii9003
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment