Fix ASCWriter millisecond handling by lumagi · Pull Request #1734 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
zariiii9003 merged 6 commits intohardbyte:mainfrom
Jan 21, 2024Merged
Fix ASCWriter millisecond handling#1734
zariiii9003 merged 6 commits intohardbyte:mainfrom
Fix ASCWriter millisecond handling#1734
zariiii9003 merged 6 commits intohardbyte:mainfrom
Conversation
Copy link
Collaborator
lumagi
commented
Jan 20, 2024
lumagi
commented
With this PR, I would like to improve the string formatting of milliseconds in the ASCWriter class.
Unfortunately, the format seems to rely on localized datetimes. I added a commit to change the date time format to 24h instead of 12h. Let me know what you think.
lumagi added 3 commits
January 20, 2024 16:42
lumagi
requested a review
from zariiii9003
lumagi
force-pushed
the
fix_asc_msec_handling
branch
from
84386ed to
31cbda8
Compare
lumagi
force-pushed
the
fix_asc_msec_handling
branch
from
31cbda8 to
160cea8
Compare
lumagi added 2 commits
January 20, 2024 18:04
Copy link
Collaborator Author
lumagi
commented
Jan 20, 2024
lumagi commented
Jan 20, 2024Supposed to fix part of the problem presented in #1699
zariiii9003 approved these changes Jan 20, 2024
Copy link
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
zariiii9003
merged commit
7e29504
into
hardbyte:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment