add silent mode support for vector by cperkulator · Pull Request #1764 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
zariiii9003 merged 3 commits intohardbyte:mainfrom
Jun 7, 2024Merged
add silent mode support for vector#1764
zariiii9003 merged 3 commits intohardbyte:mainfrom
add silent mode support for vector#1764
zariiii9003 merged 3 commits intohardbyte:mainfrom
Conversation
zariiii9003 reviewed Apr 16, 2024
can/interfaces/vector/canlib.py
Outdated
can/interfaces/vector/canlib.py Outdated
| self.index_to_channel: Dict[int, int] = {} | ||
| self._can_protocol = CanProtocol.CAN_FD if is_fd else CanProtocol.CAN_20 | ||
|
|
||
| self.silent_mode = kwargs.get('silent_mode', False) |
Copy link
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer listen_only like in socketcan. Also, make this variable private.
Copy link
Collaborator
zariiii9003
commented
Apr 16, 2024
zariiii9003 commented
Apr 16, 2024Are you still working on the failing tests?
cperkulator added 2 commits
April 19, 2024 14:11works as expected
Copy link
Contributor Author
cperkulator
commented
Apr 22, 2024
cperkulator commented
Apr 22, 2024@zariiii9003 looks like tests are passing except one that is known to periodically fail
zariiii9003 approved these changes Apr 23, 2024
Copy link
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you
Copy link
Contributor Author
cperkulator
commented
May 4, 2024
cperkulator commented
May 4, 2024@zariiii9003 is this ready to get merged in?
zariiii9003
merged commit
fc6ff22
into
hardbyte:main
cperkulator
deleted the
vector_silent_mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants