Remove abstractmethod() decorator from Listener.stop() by zariiii9003 · Pull Request #1795 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
zariiii9003 merged 1 commit intohardbyte:mainfrom
Jun 12, 2024Merged
Remove abstractmethod() decorator from Listener.stop()#1795
zariiii9003 merged 1 commit intohardbyte:mainfrom
Remove abstractmethod() decorator from Listener.stop()#1795
zariiii9003 merged 1 commit intohardbyte:mainfrom
Conversation
Copy link
Collaborator
zariiii9003
commented
Jun 12, 2024
zariiii9003
commented
Closes #1770
This is breaking some downstream code.
zariiii9003
added
the
bug
label
zariiii9003
merged commit
25d6999
into
hardbyte:main
zariiii9003
deleted the
undo_abstractmethod
branch
Copy link
Contributor
acolomb
commented
Jun 13, 2024
acolomb commented
Jun 13, 2024@hardbyte, @zariiii9003 Will you make a release with this fix soon? We're kind of trying to hurry on a release of canopen now, but having this in a v4.4.1 on PyPI would reduce the amount of troubles for downstream users in the short term.
acolomb
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment