Fix ASCReader Crash on "Start of Measurement" Line by RitheeshBaradwaj · Pull Request #1811 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
hardbyte merged 3 commits intohardbyte:mainfrom
Jul 26, 2024Merged
Fix ASCReader Crash on "Start of Measurement" Line#1811
hardbyte merged 3 commits intohardbyte:mainfrom
Fix ASCReader Crash on "Start of Measurement" Line#1811
hardbyte merged 3 commits intohardbyte:mainfrom
Conversation
Copy link
Contributor
Summary
This PR addresses an issue where the ASCReader crashes when encountering the line 0.000000 CANFD Start of measurement in ASC log files. This line is a combination of two different conventions and should not contain the "CANFD" flag.
Changes
- Added logic in the
__iter__method ofASCReaderto skip lines matching the regex pattern for "Start of measurement". - This ensures that such special indicator lines are handled separately and do not cause parsing errors.
Fixes #1786.
RitheeshBaradwaj
mentioned this pull request
Closed
hardbyte approved these changes Jul 15, 2024
Copy link
Contributor Author
RitheeshBaradwaj
commented
Jul 20, 2024
RitheeshBaradwaj commented
Jul 20, 2024@hardbyte I am unable to merge the PR. Could you please merge it?
hardbyte
merged commit
d34b2d6
into
hardbyte:main
RitheeshBaradwaj
deleted the
bugfix/asc-reader-invalid-line-crash
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants