MF4 reader updates by cssedev · Pull Request #1892 · hardbyte/python-can
Navigation Menu
{{ message }}
hardbyte / python-can Public
- Notifications You must be signed in to change notification settings
- Fork 666
Merged
MF4 reader updates#1892
hardbyte merged 7 commits intohardbyte:mainfrom
MF4 reader updates#1892
hardbyte merged 7 commits intohardbyte:mainfrom
Conversation
Copy link
Contributor
cssedev
commented
Nov 8, 2024
cssedev
commented
Continuation of PR #1884, which got lost in the rebase
cssedev added 6 commits
November 8, 2024 08:14
Copy link
Contributor Author
cssedev
commented
Nov 11, 2024
cssedev commented
Nov 11, 2024Should the commits be squished once all checks have passed?
Copy link
Owner
hardbyte
commented
Nov 12, 2024
hardbyte commented
Nov 12, 2024Should the commits be squished once all checks have passed?
Yes usually we squash and rebase once everything in the CI is passing.
Copy link
Contributor Author
cssedev
commented
Nov 12, 2024
cssedev commented
Nov 12, 2024The failing test from the last run does not seem to originate from the changes in this PR. Is there a way to re-run a single test, or do you have any idea of how to resolve the remaining issue?
hardbyte approved these changes Nov 15, 2024
Copy link
Owner
hardbyte
left a comment
hardbyte
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
hardbyte
merged commit
805f3fb
into
hardbyte:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants