Jlohmer/coalesce nil by Y0-L0 · Pull Request #31979 · helm/helm
AI review requested due to automatic review settings
March 28, 2026 19:21Copilot AI review requested due to automatic review settings
March 28, 2026 20:00Copilot AI review requested due to automatic review settings
March 29, 2026 18:11
Y0-L0
mentioned this pull request
Copilot AI review requested due to automatic review settings
March 31, 2026 09:19banjoh previously approved these changes Apr 1, 2026
Copilot AI review requested due to automatic review settings
April 1, 2026 18:25Three test cases that cover the regression scenarios introduced by the helm#31644 nil preservation fix: - subchart default nils should be cleaned up when parent doesn't set those keys (helm#31919) - user-supplied null should erase subchart defaults (helm#31919) - subchart default nil should not shadow global values via pluck (helm#31971) Tests are expected to fail until the regression is fixed. Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
Regression test for the Bitnami common.secrets.key issue. Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
Only user-supplied nils should survive coalescing. Chart-default nils defaults, not just user overrides. This caused: - %!s(<nil>) in templates using Bitnami common.secrets.key (helm#31919) - pluck fallbacks returning nil instead of falling through to globals (helm#31971) Fixes helm#31919 Fixes helm#31971 Signed-off-by: Johannes Lohmer <jojo.dev@lohmer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters