Pass the `ActionEvent` (with params) to `registerActionOption` callbacks by lb- · Pull Request #692 · hotwired/stimulus
Copy link
Contributor
lb-
commented
Jun 20, 2023
lb-
commented
- Add ability for registerActionOption callbacks to receive the event after
paramshave been resolved - Relates to Feature request - Ability to access
controllerorevent.paramsin theregisterActionOptionfunction #668
- Add ability for registerActionOption callbacks to receive the event after `params` have been resolved - Relates to hotwired#668
lb-
force-pushed
the
feature/668-action-option-callback-event-with-params
branch
from
e1f111d to
f78f032
Compare
dhh
requested a review
from adrienpoly
adrienpoly approved these changes Jun 24, 2023
Copy link
Member
adrienpoly
left a comment
adrienpoly
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @lb-
dhh
merged commit
7bf453c
into
hotwired:main
lb-
deleted the
feature/668-action-option-callback-event-with-params
branch
Copy link
Contributor Author
lb-
commented
Jun 26, 2023
lb- commented
Jun 26, 2023Thanks!
marcoroth reviewed Jul 12, 2023
docs/reference/actions.md
Show resolved
Hide resolved
docs/reference/actions.md Show resolved Hide resolved
marcoroth
mentioned this pull request
lb-
mentioned this pull request
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters