Fix (dis)connected callbacks with `targetAttributeForScope` by koenkivits · Pull Request #810 · hotwired/stimulus
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 443
Comments
Open
koenkivits wants to merge 1 commit intohotwired:mainfrom
Open
Fix (dis)connected callbacks with targetAttributeForScope#810
koenkivits wants to merge 1 commit intohotwired:mainfrom
Fix (dis)connected callbacks with targetAttributeForScope#810
koenkivits wants to merge 1 commit intohotwired:mainfrom
Conversation
Copy link
koenkivits
commented
Jan 21, 2025
koenkivits
commented
Closes #809
I wasn't quite sure if my approach for the tests -- which now always use a custom targetAttributeForScope -- is right, but I'm open to feedback. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant