Cleanup issues discovered by FindBugs by oleg-nenashev · Pull Request #210 · hub4j/github-api

Cleanup issues discovered by FindBugs by oleg-nenashev · Pull Request #210 · hub4j/github-api

Conversation

The change closes about 100 issues (mostly API ones), but there're also several changes for encodings and file streams

@reviewbybees @lanwen @KostyaSha

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, plz change to utf8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a standard for GitHub?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Content-type includes utf-8 as charset

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

👍 and squash before merge please

oleg-nenashev added a commit that referenced this pull request

Cleanup issues discovered by FindBugs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't Long.parseLong() suit better here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on what is in X-Poll-Interval but you may be right

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same, I just noticed it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case this code does not handle parsing exceptions, which may strike back at some point