Fixup ao module filter func by muellerzr · Pull Request #3450 · huggingface/accelerate
Navigation Menu
{{ message }}
huggingface / accelerate Public
- Notifications You must be signed in to change notification settings
- Fork 1.3k
Merged
Conversation
Copy link
Contributor
muellerzr
commented
Mar 20, 2025
muellerzr
commented
What does this PR do?
We modified how we pass in the layers but I didn't actually update the call in the case of the default being used
Fixes # (issue)
Before submitting
- This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- Did you read the contributor guideline,
Pull Request section? - Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case. - Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings. - Did you write any new necessary tests?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @S1ro1
muellerzr
requested a review
from SunMarc
Copy link
HuggingFaceDocBuilderDev
commented
Mar 20, 2025
HuggingFaceDocBuilderDev commented
Mar 20, 2025The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
SunMarc approved these changes Mar 21, 2025
Copy link
Member
SunMarc
left a comment
SunMarc
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
muellerzr
deleted the
fix-fp8-benchmarks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment