fix(url): fix panic when questionmark is in fragment by sinkuu · Pull Request #1076 · hyperium/hyper
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Merged
seanmonstar merged 1 commit intohyperium:masterfrom
Feb 25, 2017Merged
fix(url): fix panic when questionmark is in fragment#1076
seanmonstar merged 1 commit intohyperium:masterfrom
fix(url): fix panic when questionmark is in fragment#1076
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
Copy link
Contributor
- The commit messages match the guidelines in https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md#git-commit-guidelines
Url::parse panicked if a questionmark is in the fragment part:
panicked at 'attempt to subtract with overflow', src/uri.rs:207
This was found by cargo-fuzz
Copy link
Member
seanmonstar
commented
Feb 25, 2017
seanmonstar commented
Feb 25, 2017Excellent, thank you!
seanmonstar
merged commit
359f5ff
into
hyperium:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants