goroutine leak fixed by pfi79 · Pull Request #5214 · hyperledger/fabric
Navigation Menu
{{ message }}
hyperledger / fabric Public
- Notifications You must be signed in to change notification settings
- Fork 9.1k
Merged
yacovm merged 1 commit intohyperledger:mainfrom
May 5, 2025Merged
goroutine leak fixed#5214
yacovm merged 1 commit intohyperledger:mainfrom
goroutine leak fixed#5214
yacovm merged 1 commit intohyperledger:mainfrom
Conversation
Copy link
Contributor
pfi79
commented
May 4, 2025
pfi79
commented
Because grpc clients are not closed, there is a leak of goroutines.
This change fixes this
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
pfi79
requested a review
from a team
as a code owner
yacovm reviewed May 5, 2025
| @@ -186,8 +189,7 @@ func (hr *BFTHeaderReceiver) Stop() error { | |||
|
|
|||
| hr.logger.Infof("[%s][%s] Stopping", hr.chainID, hr.endpoint) | |||
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well at least we have a stop function :-)
yacovm approved these changes May 5, 2025
pfi79
deleted the
goroutines-leak
branch
Copy link
Contributor Author
pfi79
commented
May 5, 2025
pfi79 commented
May 5, 2025
Copy link
Contributor
tock-ibm
commented
May 6, 2025
tock-ibm commented
May 6, 2025@pfi79 Thanks for picking that up! At least I left TODOs in the right places ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants