✨ feat: 优化批量下载 by kazukokawagawa · Pull Request #606 · imsyy/SPlayer
Summary of Changes
Hello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the user experience and robustness of the application's download features. It introduces a visual progress indicator for batch downloads, adds an option to prevent re-downloading existing files, and provides an alternative download mechanism to address potential issues. Additionally, it refines metadata handling during downloads and expands lyric download customization options.
Highlights
- Enhanced Download Logic: The core download functionality has been significantly updated to provide more detailed status (success, skipped, error) and includes a new option to skip downloading files that already exist locally. It also introduces a mechanism to clear existing ID3 tags before writing new metadata, preventing potential data corruption.
- Batch Download Progress UI: A new, dedicated notification UI has been implemented for batch downloads, providing real-time progress updates including the current song being downloaded, overall percentage, transferred size, and success count. This replaces the previous message-based progress indicator.
- Alternative Download Method: A new setting, 'Simulate Playback Download,' has been added. When enabled, the application will use the playback API (
songUrl) for downloads instead of the direct download API (songDownloadUrl), which may resolve certain download issues. - Improved Batch Download Feedback: The batch download completion dialog now provides a more detailed list of failed songs, and a notification is displayed when a file is skipped because it already exists.
- New Settings for Lyrics: New settings have been introduced to control the downloading of lyric translations and romaji lyrics.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩