chore: delete unnecessary inheritance of FlowableBufferTimedFlushable by OrezzerO · Pull Request #794 · influxdata/influxdb-client-java
Closes #
Proposed Changes
FlowableBufferTimedFlushable doesn't need to inherit from FlowableTransformer. Therefore, delete this inheritance relationship to reduce the complexity of the code. The original implementation was quite confusing.
Checklist
- CHANGELOG.md updated
- Rebased/mergeable
- A test has been added if appropriate
-
mvn testcompletes successfully - Commit messages are conventional
- Sign CLA (if not already signed)
⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (f9283d6) to head (50589b1).
⚠️ Report is 57 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## master #794 +/- ## ============================================ + Coverage 88.50% 88.51% +0.01% + Complexity 787 785 -2 ============================================ Files 174 174 Lines 7203 7202 -1 Branches 405 405 ============================================ Hits 6375 6375 + Misses 697 696 -1 Partials 131 131
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
…rTimedFlushable The class no longer requires inheritance from FlowableBufferTimedFlushable as its functionality is redundant. Simplified the class hierarchy for better maintainability.
@OrezzerO, please add a new section titled “Features” to the 7.3.0 release notes. Thank you! 😊
bednar
changed the title
Delete unnecessary inheritance of FlowableBufferTimedFlushable
chore: delete unnecessary inheritance of FlowableBufferTimedFlushable
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters