JCL 339: Upgrade JsonB module to use Jakarta EE 10 by bncummings · Pull Request #432 · inrupt/solid-client-java
Navigation Menu
{{ message }}
inrupt / solid-client-java Public
- Notifications You must be signed in to change notification settings
- Fork 7
Merged
Conversation
Copy link
Contributor
bncummings
commented
Apr 24, 2023
bncummings
commented
I had to change <jakarta.json.version> from 1.1.6 to 2.0.1 (which was the most recent and popular version that didn't cause conflicts). This wasn't explicitly mentioned in the ticket but the package jakarta.json.JsonException wasn't recognised in 1.1.6. Would appreciate any feedback as I'm unsure which version would be most appropriate.
bncummings
requested a review
from a team
as a code owner
bncummings
temporarily deployed
to
ESS PodSpaces
— with
GitHub Actions
Inactive
bncummings
temporarily deployed
to
ESS PodSpaces
— with
GitHub Actions
Inactive
acoburn added 2 commits
May 1, 2023 12:41acoburn approved these changes May 1, 2023
Copy link
Collaborator
acoburn
left a comment
acoburn
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- I moved the JSON-API dependency to 2.1.1 (newer) and separated that version management from the glassfish implementation dependency
acoburn
enabled auto-merge (squash)
acoburn
merged commit
51e907e
into
main
acoburn
deleted the
JCL-339-upgrade-json-b-module-to-use-jakarta-ee-10
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants