JCL-349: Better concurrency support for OpenID session refresh by acoburn · Pull Request #456 · inrupt/solid-client-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@acoburn

Copy link

Collaborator

@acoburn acoburn commented

May 15, 2023

edited

Loading

At present, in a highly concurrent environment, when a token expires, many threads may try to simultaneously refresh the OpenID session credential. This change combines an executor with a synchronized method to ensure that no more than one thread tries to perform that refresh flow at a time

@acoburn acoburn requested a review from a team as a code owner

May 15, 2023 18:12

@acoburn acoburn temporarily deployed to ESS PodSpaces

May 15, 2023 18:12

— with GitHub Actions Inactive

@acoburn acoburn temporarily deployed to ESS PodSpaces

May 15, 2023 18:12

— with GitHub Actions Inactive

@acoburn acoburn temporarily deployed to ESS DevNext

May 15, 2023 18:12

— with GitHub Actions Inactive

@acoburn acoburn merged commit 91e77cf into main

May 16, 2023

@acoburn acoburn deleted the JCL-349-openid-concurrency branch

May 16, 2023 10:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timea-solid timea-solid timea-solid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acoburn @timea-solid