JCL-356: Prohibit weak authorization mechanisms by acoburn · Pull Request #479 · inrupt/solid-client-java
Navigation Menu
{{ message }}
inrupt / solid-client-java Public
- Notifications You must be signed in to change notification settings
- Fork 7
Merged
JCL-356: Prohibit weak authorization mechanisms#479
JCL-356: Prohibit weak authorization mechanisms#479
Conversation
Copy link
Collaborator
acoburn
commented
May 24, 2023
acoburn
commented
This explicitly prohibits the use of Basic and Digest auth schemes.
acoburn
requested a review
from a team
as a code owner
NSeydoux reviewed May 24, 2023
api/src/main/java/com/inrupt/client/auth/ReactiveAuthorization.java
Show resolved
Hide resolved
api/src/main/java/com/inrupt/client/auth/ReactiveAuthorization.java Show resolved Hide resolved
NSeydoux approved these changes May 24, 2023
acoburn
force-pushed
the
JCL-356-prohibit-weak-auth
branch
from
5c2a70b to
2c8a2ae
Compare
acoburn
enabled auto-merge (squash)
langsamu suggested changes May 24, 2023
Copy link
Contributor
langsamu
left a comment
langsamu
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to @NSeydoux's point, can we document this behaviour in the class javadoc?
acoburn added 4 commits
May 24, 2023 08:20
acoburn
force-pushed
the
JCL-356-prohibit-weak-auth
branch
from
c378afe to
df1a028
Compare
langsamu approved these changes May 24, 2023
acoburn
merged commit
943990a
into
main
acoburn
deleted the
JCL-356-prohibit-weak-auth
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants