Dynamic imports by lhmisho · Pull Request #27 · javascript-tutorial/bn.javascript.info

Error: the article already has PR number in the Progress Issue #1, it's 24 ⁉️

Sorry, Brother @lhmisho you have raised a PR #27 where the files belong The old "var" contents. but the PR title is Dynamic imports. hope you understand.

Dear Jamal Bhaii, As your instruction i just separated my master into two different branch and made PR separately. But there is also some other issues. I am really confused to what to do. Please help me. Thank you.

…

You have translated the wrong file. Please check your title and contents before creating a PR. Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ভুল অনুবাদ হয়েছে। ঠিক করে পুল রিকুয়েস্ট আপডেট করতে হবে।

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@lhmisho আপনাকে এখানে /done লিখে কমেন্ট করতে হবে। তাহলে আমরা আবার রিভিউ করতে পারবো।
ধন্যবাদ।

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ঠিক আছে। ছোট একটা পরিবর্তন আছে। ঠিক হলে এপ্রুভ করা যেতে পারে।
ধন্যবাদ।


		```js
		import ... from !getModuleName()/!; // Error, only from "string" is allowed
		import ... from !getModuleName()/!; এরর, শুধুমাত্র "string" প্রযোজ্য

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	import ... from !getModuleName()/!; এরর, শুধুমাত্র "string" প্রযোজ্য
	import ... from !getModuleName()/!; // এরর, শুধুমাত্র "string" প্রযোজ্য

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

/done

…

On Mon, Nov 4, 2019 at 10:04 PM JavaScript Translate Bot < ***@***.***> wrote: Please make the requested changes. After it, add a comment "/done". Then I'll ask for a new review 👻 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27?email_source=notifications&email_token=ACZH2OQNNMCVRBIRIV76FCLQSBBX5A5CNFSM4JFRKWO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7YMSY#issuecomment-549422667>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZH2ORT5U7A5FUEF5L5FIDQSBBX5ANCNFSM4JFRKWOQ> .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-time ago you seek my help for git conflicts. I am really apologize for my late response, I was super busy last few days and Alhamdulillah, You are the king 👑 here, you solved your problem and finally your PR #27 is going to merge. Thanks for your hard work 🐺 . wish you good luck 💯 👍 ❤️

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

It's always a great importunity to be a contributor of something which is provably going to helps our community. And thanks Dear @md. Jamal Uddin bhaii for your feedback.

…

On Thu, Nov 7, 2019 at 10:12 AM JavaScript Translate Bot < ***@***.***> wrote: Thank you 💖 I updated the Progress Issue #1 <#1> 🎉 🎉 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27?email_source=notifications&email_token=ACZH2OS5QBV4OD7TEVP43N3QSOISXA5CNFSM4JFRKWO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDJPIUA#issuecomment-550696016>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZH2OV6WQ4BXHVAYL6HJTLQSOISXANCNFSM4JFRKWOQ> .