Keyboard: keydown and keyup by pierangelomiceli · Pull Request #265 · javascript-tutorial/it.javascript.info
Navigation Menu
{{ message }}
javascript-tutorial / it.javascript.info Public
- Notifications You must be signed in to change notification settings
- Fork 60
Merged
pasor1 merged 6 commits intojavascript-tutorial:masterfrom
Mar 24, 2021Merged
Keyboard: keydown and keyup#265
pasor1 merged 6 commits intojavascript-tutorial:masterfrom
Keyboard: keydown and keyup#265
pasor1 merged 6 commits intojavascript-tutorial:masterfrom
Conversation
pierangelomiceli added 4 commits
March 14, 2021 14:18
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
javascript-translate-bot
mentioned this pull request
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/solution.view/index.html
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/solution.view/index.html Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
Dorin-David reviewed Mar 19, 2021
Copy link
Contributor
Dorin-David
left a comment
Dorin-David
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ottima traduzione Pier! Mi sono permesso di suggerire alcune piccole modifiche, fanne quello che vuoi.
longo-andrea
added
changes requested
needs +1
and removed
review needed
labels
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
Copy link
Contributor Author
pierangelomiceli
commented
Mar 20, 2021
pierangelomiceli commented
Mar 20, 2021/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
longo-andrea
removed
the
review needed
label
pasor1 requested changes Mar 21, 2021
2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/solution.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/solution.md Outdated Show resolved Hide resolved
2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/task.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/task.md Outdated Show resolved Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md
Outdated
Show resolved
Hide resolved
2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved
javascript-translate-bot
added
the
changes requested
label
Copy link
javascript-translate-bot
commented
Mar 21, 2021
javascript-translate-bot commented
Mar 21, 2021Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
pasor1
added
2nd review done
and removed
needs +1
labels
Copy link
Contributor
longo-andrea
commented
Mar 23, 2021
longo-andrea commented
Mar 23, 2021visto che è aperta da oltre una settimana, prendo io in carico le modifiche suggerite cosi poi è pronta per il merge
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Copy link
Contributor
longo-andrea
commented
Mar 23, 2021
longo-andrea commented
Mar 23, 2021/done
longo-andrea
added
ready to merge
and removed
changes requested
labels
pasor1 approved these changes Mar 23, 2021
javascript-translate-bot
added
the
needs +1
label
pasor1
removed
2nd review done
needs +1
labels
Copy link
Contributor Author
pierangelomiceli
commented
Mar 23, 2021
pierangelomiceli commented
Mar 23, 2021potete fare merge quando volete.
pasor1
merged commit
60f5c83
into
javascript-tutorial:master
Copy link
javascript-translate-bot
commented
Mar 24, 2021
javascript-translate-bot commented
Mar 24, 2021Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment