Popups and window methods by longo-andrea · Pull Request #269 · javascript-tutorial/it.javascript.info
Navigation Menu
{{ message }}
javascript-tutorial / it.javascript.info Public
- Notifications You must be signed in to change notification settings
- Fork 60
Merged
longo-andrea merged 3 commits intojavascript-tutorial:masterfrom
Mar 28, 2021Merged
longo-andrea merged 3 commits intojavascript-tutorial:masterfrom
longo-andrea merged 3 commits intojavascript-tutorial:masterfrom
Conversation
longo-andrea added 2 commits
March 19, 2021 21:01
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
javascript-translate-bot
mentioned this pull request
pasor1 requested changes Mar 26, 2021
Copy link
Member
pasor1
left a comment
pasor1
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corretto qualche "typo".
In molte situazioni ho suggerito "finestra popup" anziché "finestra di popup",
Idem per "il tab" al posto di "la tab" , ma qui si va un po' ad abitudine personale, anche se in genere i neologismi prendono il maschile.
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/01-popup-windows/article.md
Outdated
Show resolved
Hide resolved
3-frames-and-windows/01-popup-windows/article.md Outdated Show resolved Hide resolved
javascript-translate-bot
removed
the
review needed
label
Copy link
javascript-translate-bot
commented
Mar 26, 2021
javascript-translate-bot commented
Mar 26, 2021Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
javascript-translate-bot
added
the
changes requested
label
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Copy link
Contributor Author
longo-andrea
commented
Mar 26, 2021
longo-andrea commented
Mar 26, 2021/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
javascript-translate-bot
requested a review
from a team
longo-andrea
added
the
needs +1
label
longo-andrea
merged commit
a65802b
into
javascript-tutorial:master
Copy link
javascript-translate-bot
commented
Mar 28, 2021
javascript-translate-bot commented
Mar 28, 2021Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
longo-andrea
deleted the
article/popup-windows
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment