Strings by gingano · Pull Request #230 · javascript-tutorial/uk.javascript.info

Strings by gingano · Pull Request #230 · javascript-tutorial/uk.javascript.info

Skip to content

Merged

tarasyyyk merged 9 commits intojavascript-tutorial:masterfrom

gingano:translation/strings

Dec 18, 2021

Merged

Strings#230
tarasyyyk merged 9 commits intojavascript-tutorial:masterfrom
gingano:translation/strings

Conversation

Copy link

Contributor

gingano commented
Dec 9, 2021

Strings

oleksii-kovalenko-gingano added 2 commits

December 9, 2021 14:42

translation added

translation for tasks added

javascript-translate-bot added the review needed label

Copy link

Contributor

javascript-translate-bot commented
Dec 9, 2021

Error: the article has another translator @gingano) [translation requested](#1 (comment) in the Progress Issue #1.

Copy link

CLAassistant commented
Dec 9, 2021
•

edited

Loading

All committers have signed the CLA.

Copy link

Contributor Author

gingano commented
Dec 9, 2021

Error: the article has another translator @gingano) [translation requested](#1 (comment) in the Progress Issue #1.

@tarasyyyk it's ok ?

tarasyyyk requested changes Dec 12, 2021

View reviewed changes

Copy link

Collaborator

tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дуже об’ємний переклад! Дякую за старання!
Я додав декілька правок

1-js/05-data-types/03-string/1-ucfirst/_js.view/test.js Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/1-ucfirst/_js.view/test.js Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/1-ucfirst/solution.md Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/1-ucfirst/solution.md Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/2-check-spam/_js.view/test.js Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

javascript-translate-bot removed the review needed label

Copy link

Contributor

javascript-translate-bot commented
Dec 12, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

translation refactoring

Copy link

Contributor Author

gingano commented
Dec 15, 2021

/done

javascript-translate-bot added review needed and removed changes requested labels

gingano requested a review from tarasyyyk

December 15, 2021 08:41

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/3-truncate/_js.view/test.js Outdated Show resolved Hide resolved

Update 1-js/05-data-types/03-string/3-truncate/_js.view/test.js

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

Update 1-js/05-data-types/03-string/article.md

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

Update 1-js/05-data-types/03-string/article.md

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

Update 1-js/05-data-types/03-string/article.md

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk reviewed Dec 17, 2021

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated Show resolved Hide resolved

tarasyyyk added 2 commits

December 17, 2021 20:54

Apply suggestions from code review

Final corrections

tarasyyyk approved these changes Dec 17, 2021

View reviewed changes

Copy link

Collaborator

tarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нарешті переклад цієї величезної статті завершено!
Велике Спасибі!

javascript-translate-bot added needs +1 and removed review needed labels

Copy link

Collaborator

tarasyyyk commented
Dec 17, 2021

@gingano, залишилось підписати CLA.

tarasyyyk added ready to merge and removed needs +1 labels

gingano requested a review from tarasyyyk

December 18, 2021 12:49

Copy link

Contributor Author

gingano commented
Dec 18, 2021

@tarasyyyk підписав, можеш мерджити

Copy link

Collaborator

tarasyyyk commented
Dec 18, 2021

@all-contributors add @gingano for translation.

allcontributors bot mentioned this pull request

docs: add gingano as a contributor for translation #237

Merged

Copy link

Contributor

allcontributors bot commented
Dec 18, 2021

I've put up a pull request to add @gingano! 🎉

tarasyyyk approved these changes Dec 18, 2021

View reviewed changes

javascript-translate-bot added the needs +1 label

tarasyyyk merged commit a92f1be into javascript-tutorial:master

Copy link

Contributor

javascript-translate-bot commented
Dec 18, 2021

Error: the article has another translator @gingano) [translation requested](#1 (comment), not @gingano in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

tarasyyyk mentioned this pull request

Ukrainian Translation Progress #1

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 ready to merge

5 participants