Switch by lobanov-oleh · Pull Request #42 · javascript-tutorial/uk.javascript.info
Navigation Menu
{{ message }}
javascript-tutorial / uk.javascript.info Public
- Notifications You must be signed in to change notification settings
- Fork 184
Merged
tarasyyyk merged 3 commits intojavascript-tutorial:masterfrom
Aug 14, 2019Merged
Switch#42
tarasyyyk merged 3 commits intojavascript-tutorial:masterfrom
Switch#42
tarasyyyk merged 3 commits intojavascript-tutorial:masterfrom
Conversation
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
Copy link
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
tarasyyyk requested changes Aug 14, 2019
Copy link
Collaborator
tarasyyyk
left a comment
tarasyyyk
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great translation! Please, fix small issue and I'll merge thit PR to master.
1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/task.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/13-switch/2-rewrite-if-switch/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/13-switch/2-rewrite-if-switch/solution.md Outdated Show resolved Hide resolved
javascript-translate-bot
added
changes requested
and removed
review needed
labels
Copy link
Contributor
javascript-translate-bot
commented
Aug 14, 2019
javascript-translate-bot commented
Aug 14, 2019Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
lobanov-oleh added 2 commits
August 14, 2019 17:41tarasyyyk approved these changes Aug 14, 2019
javascript-translate-bot
added
needs +1
and removed
changes requested
labels
tarasyyyk
merged commit
186b3c5
into
javascript-tutorial:master
iliakan
mentioned this pull request
javascript-tutorial
deleted a comment from
allcontributors bot
javascript-tutorial
deleted a comment from
allcontributors bot
javascript-tutorial
deleted a comment from
allcontributors bot
Copy link
Collaborator
tarasyyyk
commented
Mar 6, 2020
tarasyyyk commented
Mar 6, 2020Thanks for contribution!
@all-contributors add @lobanov-oleh for translation.
allcontributors
bot
mentioned this pull request
Copy link
Contributor
allcontributors
bot
commented
Mar 6, 2020
allcontributors bot commented
Mar 6, 2020I've put up a pull request to add @lobanov-oleh! 🎉
tarasyyyk
removed
the
needs +1
label
tarasyyyk
changed the title
1_02_13 switch
Switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants