Coding Style by ImVietnam ยท Pull Request #174 ยท javascript-tutorial/vi.javascript.info
Navigation Menu
{{ message }}
javascript-tutorial / vi.javascript.info Public
- Notifications You must be signed in to change notification settings
- Fork 44
Merged
Coding Style#174
tunggnu merged 25 commits intojavascript-tutorial:masterfrom
Coding Style#174
tunggnu merged 25 commits intojavascript-tutorial:masterfrom
Conversation
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
javascript-translate-bot
mentioned this pull request
ImVietnam added 14 commits
February 22, 2023 09:58henryonsoftware suggested changes Feb 23, 2023
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/task.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/task.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/task.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/task.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
javascript-translate-bot
added
changes requested
and removed
review needed
labels
Copy link
javascript-translate-bot
commented
Feb 23, 2023
javascript-translate-bot commented
Feb 23, 2023Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review ๐ป
ImVietnam added 3 commits
February 25, 2023 13:03Copy link
Contributor Author
ImVietnam
commented
Feb 25, 2023
ImVietnam commented
Feb 25, 2023/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
javascript-translate-bot
requested a review
from a team
henryonsoftware
removed
the
review needed
label
henryonsoftware
added
the
changes requested
label
Copy link
Contributor Author
ImVietnam
commented
Mar 1, 2023
ImVietnam commented
Mar 1, 2023/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
henryonsoftware approved these changes Mar 1, 2023
Copy link
Contributor
henryonsoftware
left a comment
henryonsoftware
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
javascript-translate-bot
added
needs +1
and removed
review needed
labels
henryonsoftware
requested a review
from tunggnu
tunggnu requested changes Jun 8, 2023
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/task.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/1-style-errors/task.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md
Outdated
Show resolved
Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
javascript-translate-bot
added
the
changes requested
label
Copy link
javascript-translate-bot
commented
Jun 8, 2023
javascript-translate-bot commented
Jun 8, 2023Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review ๐ป
ImVietnam added 4 commits
June 8, 2023 12:26Copy link
Contributor Author
ImVietnam
commented
Jun 8, 2023
ImVietnam commented
Jun 8, 2023/done
javascript-translate-bot
added
review needed
and removed
changes requested
labels
javascript-translate-bot
requested a review
from a team
tunggnu approved these changes Jun 8, 2023
Copy link
Contributor
tunggnu
left a comment
tunggnu
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
tunggnu
merged commit
94a73bd
into
javascript-tutorial:master
Copy link
javascript-translate-bot
commented
Jun 8, 2023
javascript-translate-bot commented
Jun 8, 2023Thank you ๐ I updated the Progress Issue #1 ๐ ๐ ๐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment