Functions by hoangnv170752 · Pull Request #222 · javascript-tutorial/vi.javascript.info
Navigation Menu
{{ message }}
javascript-tutorial / vi.javascript.info Public
- Notifications You must be signed in to change notification settings
- Fork 44
Merged
tunggnu merged 5 commits intojavascript-tutorial:masterfrom
Jul 15, 2024Merged
Functions#222
tunggnu merged 5 commits intojavascript-tutorial:masterfrom
Functions#222
tunggnu merged 5 commits intojavascript-tutorial:masterfrom
Conversation
javascript-translate-bot
added
the
review needed
label
javascript-translate-bot
requested a review
from a team
Copy link
All committers have signed the CLA.
javascript-translate-bot
mentioned this pull request
Copy link
Contributor Author
hoangnv170752
commented
Jul 13, 2024
hoangnv170752 commented
Jul 13, 2024@tunggnu & @henryonsoftware xin phép ping các anh về phần review và merge ạ
tunggnu requested changes Jul 13, 2024
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
javascript-translate-bot
added
changes requested
and removed
review needed
labels
Copy link
javascript-translate-bot
commented
Jul 13, 2024
javascript-translate-bot commented
Jul 13, 2024Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Copy link
Contributor
tunggnu
commented
Jul 13, 2024
tunggnu commented
Jul 13, 2024@hoangnv170752 bạn cần ký thỏa thuận tác quyền ở link này #222 (comment)
hoangnv170752 commented Jul 13, 2024
Copy link
Contributor Author
hoangnv170752
left a comment
hoangnv170752
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Em có đẩy 1 commit mới sửa các lỗi dịch ạ
tunggnu
self-assigned this
hoangnv170752
requested a review
from tunggnu
tunggnu requested changes Jul 13, 2024
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/1-if-else-required/task.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/1-if-else-required/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/3-min/solution.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/3-min/solution.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
Copy link
javascript-translate-bot
commented
Jul 13, 2024
javascript-translate-bot commented
Jul 13, 2024Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
hoangnv170752
requested a review
from tunggnu
tunggnu requested changes Jul 14, 2024
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md
Outdated
Show resolved
Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
Copy link
javascript-translate-bot
commented
Jul 14, 2024
javascript-translate-bot commented
Jul 14, 2024Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Copy link
Contributor
tunggnu
commented
Jul 14, 2024
tunggnu commented
Jul 14, 2024@hoangnv170752 bạn xem lại 3 bình luận của mình ở trên để sửa nội dung tương ứng, sửa xong cái nào bạn bấm Resolve conversation để đóng bình luận đó lại.
hoangnv170752
requested a review
from tunggnu
Copy link
Contributor
tunggnu
commented
Jul 15, 2024
tunggnu commented
Jul 15, 2024@hoangnv170752 còn bình luận này bạn chưa xử lý #222 (comment)
Copy link
Contributor Author
hoangnv170752
commented
Jul 15, 2024
hoangnv170752 commented
Jul 15, 2024Em đã hoàn thiện ạ @tunggnu
tunggnu approved these changes Jul 15, 2024
javascript-translate-bot
added
needs +1
and removed
changes requested
labels
tunggnu
merged commit
3c4c432
into
javascript-tutorial:master
Copy link
javascript-translate-bot
commented
Jul 15, 2024
javascript-translate-bot commented
Jul 15, 2024Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment