Fixes utils.cpp to support electron by lygstate · Pull Request #532 · joeferner/node-java
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 290
Closed
Fixes utils.cpp to support electron#532
lygstate wants to merge 1 commit intojoeferner:masterfrom
Fixes utils.cpp to support electron#532
lygstate wants to merge 1 commit intojoeferner:masterfrom
Conversation
joeferner reviewed Aug 27, 2021
| return ab; | ||
| Nan::MaybeLocal<v8::Object> buf = Nan::NewBuffer((char*)elems, length); | ||
| v8::Local<v8::Object> v8Buf = buf.ToLocalChecked(); | ||
| Nan::MaybeLocal<v8::Value> ab = Nan::Get(v8Buf, Nan::New<v8::String>("cause").ToLocalChecked()); |
Copy link
Owner
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What am I missing here? "cause"?
ddrigass
mentioned this pull request
joeferner
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants