check that inverseDef exists before attempting to setup Inverse for belongsTo by pik · Pull Request #382 · js-data/js-data
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 137
Merged
jmdobry merged 3 commits intojs-data:masterfrom
Aug 3, 2016Merged
check that inverseDef exists before attempting to setup Inverse for belongsTo#382
jmdobry merged 3 commits intojs-data:masterfrom
check that inverseDef exists before attempting to setup Inverse for belongsTo#382
jmdobry merged 3 commits intojs-data:masterfrom
Conversation
Copy link Copy Markdown
Contributor
pik
commented
Aug 2, 2016
pik
commented
The only real change in this PR is the addition of guard conditions - but this also extracts removeInverseRelation / setupInverseRelation to their own functions. Currently the descriptor set is a very fat method and difficult to test (as well as to read). As a side effect, safeSetLink and safeSetProp got moved to utils.
pik added 3 commits
August 2, 2016 14:35
jmdobry
mentioned this pull request
jmdobry
merged commit
1366b46
into
js-data:master
jmdobry
modified the milestone:
3.0.0 Release Candidate
jmdobry
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment