UMDifying js-data-angular by kentcdodds · Pull Request #312 · js-data/js-data-angular

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kentcdodds

Copy link Copy Markdown

Closes #308

@jmdobry

Copy link Copy Markdown

Member

jmdobry commented

Mar 3, 2015

So how does this play with the browserify build? Is the browserify build even needed anymore?

@kentcdodds

Copy link Copy Markdown

Author

I think that this lib doesn't really need browserify honestly. It's pretty small/simple... I'm not sure what browserify is giving you TBH... Though, anytime you want to bring in another dependency, you've gotta add it yourself...

@kentcdodds

Copy link Copy Markdown

Author

But single-file libs are normally fairly easy to write without a bundler.

jmdobry added a commit that referenced this pull request

Mar 5, 2015

@jmdobry jmdobry merged commit 2176abd into js-data:master

Mar 5, 2015

jmdobry added a commit that referenced this pull request

Mar 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Export the module name

2 participants

@kentcdodds @jmdobry