Fix exports for some bundlers by proudparrot2 · Pull Request #166 · jshttp/cookie

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Comments

Merged

blakeembrey merged 1 commit intojshttp:masterfrom

proudparrot2:patch-1

Oct 2, 2024

Merged

Fix exports for some bundlers#166

blakeembrey merged 1 commit intojshttp:masterfrom

proudparrot2:patch-1

Conversation

@proudparrot2

Copy link

Contributor

I've been using this package in a javascript library with esbuild and it's worked fine, but for some reason, rspack can't resolve it. Adding "main": "index.js" to package.json fixed this.

@wesleytodd

Copy link

Member

While this is a good change and likely to land here, you might want to report that as a bug to them. The default behavior when main is missing is to use index.js: https://nodejs.org/docs/latest/api/modules.html#folders-as-modules

pi0 reacted with thumbs up emoji

@blakeembrey blakeembrey merged commit 927d48a into jshttp:master

Oct 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@proudparrot2 @wesleytodd @blakeembrey